Skip to content

Updated docs for PEM format support#18635

Merged
mosabua merged 1 commit intotrinodb:masterfrom
simpligility:pem
Aug 31, 2023
Merged

Updated docs for PEM format support#18635
mosabua merged 1 commit intotrinodb:masterfrom
simpligility:pem

Conversation

@mosabua
Copy link
Copy Markdown
Member

@mosabua mosabua commented Aug 10, 2023

Description

Specifically add that password protected PEM files are not supported.

FYI jdsjdk

Additional context and related issues

Result of discussion in #17300

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Aug 10, 2023
@mosabua mosabua requested a review from electrum August 10, 2023 23:37
@github-actions github-actions bot added the docs label Aug 11, 2023
@mosabua
Copy link
Copy Markdown
Member Author

mosabua commented Aug 21, 2023

Wdyt @electrum ?

Comment thread docs/src/main/sphinx/security/tls.md Outdated
Copy link
Copy Markdown
Member

@electrum electrum Aug 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about

JKS keystores always require a password, while PEM files with passwords are not supported by Trino. For JKS, add the following line to the configuration:

Note that the wording "PEM certificate" in this document is not really correct, since a PEM file used as a keystore will contain both a private key and a certificate. But we can address that as a follow up.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated .. and will do follow up PR for the file vs certificate

- Specifically add that password protected PEM files are not supported.
@mosabua mosabua merged commit e4a2748 into trinodb:master Aug 31, 2023
@mosabua mosabua deleted the pem branch August 31, 2023 20:08
@github-actions github-actions bot added this to the 426 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants