Fix structure and execution of type tests#18594
Merged
martint merged 1 commit intotrinodb:masterfrom Aug 10, 2023
Merged
Conversation
Do not use inheritance/overriding for code reuse and specialization, as it makes it harder to reason about what's being tested. Also, annotate the tests directly so that they are picked up by JUnit
hashhar
reviewed
Aug 9, 2023
Member
hashhar
left a comment
There was a problem hiding this comment.
how do we plan to deal with evolving tests? e.g. if you add a new test testRange then how do you identify which all test classes it should go into? Similarly how do you ensure there isn't a drift in the test method definition across classes.
findinpath
approved these changes
Aug 9, 2023
Member
Author
|
Each type needs tests according to its semantics. If you add new behavior to a type that affects how getRange() works, the corresponding tests for that type need to be adjusted. That's no different than how we implement tests for timestamp, timestamp w/ tz, time, time w/ tz, etc. in io.trino.operator.scalar.timestamp.TestTimestamp, io.trino.operator.scalar.timestamp.TestTime, and friends. |
dain
approved these changes
Aug 10, 2023
findepi
reviewed
Aug 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not use inheritance/overriding for code reuse and specialization, as it makes it harder to reason about what's being tested.
Also, annotate the tests directly so that they are picked up by JUnit
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.