Document postgresql.include-system-tables config property#18574
Document postgresql.include-system-tables config property#18574mosabua merged 1 commit intotrinodb:masterfrom
postgresql.include-system-tables config property#18574Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
There was a problem hiding this comment.
This file is jdbc-common-configurations.fragment which is used from several connectors. Please move to postgresql.rst.
There was a problem hiding this comment.
"Supports reading PostgreSQL system tables, e.g., pg_catalog relations."
There was a problem hiding this comment.
Please update the commit title as "Document postgresql.include-system-tables config property"
https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md#format-git-commit-messages
ebyhr
changed the title
postgresql.include-system-tables config property
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
There was a problem hiding this comment.
Please rebase on master to resolve conflicts. The file was converted to markdown.
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
1 similar comment
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
There was a problem hiding this comment.
| It also supports reading PostgreSQL system tables, e.g., `pg_catalog` relations. | |
| It also supports reading PostgreSQL system tables, such as `pg_catalog`. |
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
This content should be moved up into the Configuration section .. maybe under a separate subtitle "Access to system tables"
There was a problem hiding this comment.
| The functionality is disabled by default but this can be enabled using the ``postgresql.include-system-tables`` configuration property. | |
| The functionality is disabled by default, and can be enabled using the ``postgresql.include-system-tables`` configuration property. |
|
Also .. please rebase and send a signed CLA. |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
I have send the CLA multiple times. I have changed my email and sent again. |
Looks like it was not yet added to https://github.com/trinodb/cla/blob/master/contributors |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
Ankan0011
force-pushed
the
#15424_issue_doc_update
branch
from
eb9bd24 to
3974b73
Compare
There was a problem hiding this comment.
According to that URL there is no pg_tables table...
Ankan0011
force-pushed
the
#15424_issue_doc_update
branch
from
3974b73 to
fc69718
Compare
mosabua
force-pushed
the
#15424_issue_doc_update
branch
from
fc69718 to
4fe0877
Compare
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
Fixed the last issues and the commit message. Merging.
3 participants
Description
Added in general postgreSQL connector configuration in the documentation for support for reading PostgreSQL system tables, e.g., pg_catalog relations. The functionality is disabled by default.
Additional context and related issues
Fixes #15424
Relates to https://trinodb.slack.com/archives/CGB0QHWSW/p1671165424335919
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: