Stop testing compatibility against Databricks 7.3#18538
Stop testing compatibility against Databricks 7.3#18538ebyhr merged 2 commits intotrinodb:masterfrom
Conversation
7bd99a9 to
7aa6790
Compare
7aa6790 to
6dd99c5
Compare
|
some checks have failed |
ebyhr
left a comment
There was a problem hiding this comment.
Please remove 7.3 LTS from delta-lake.rst:
* Tables written by Databricks Runtime 7.3 LTS, 9.1 LTS, 10.4 LTS, 11.3 LTS, and
12.2 LTS are supported.
6dd99c5 to
5ab7b0f
Compare
There was a problem hiding this comment.
While at it, would it make sense to capture some tables created by 7.3 as static test resources and run tests against them?
Then we wouldn't change this file. Of course it's less about changing this file, but more about staying compatible with data out there. We should be able to read any Delta table, including those written by DBR << 7.
There was a problem hiding this comment.
BTW, I think most of the initial tables from the test resources used for testing trino-delta-lake are actually created with Databricks 7.3.
Trino can likely read as well tables written with non-LTS version of Databricks, but we're not mentioning this here.
I think there's no loss / misleading information if we remove 7.3 LTS from the documentation.
There was a problem hiding this comment.
I care less about docs, and more about testing coverage.
Tables created by DBR 7.3 do exist in the world and we must keep supporting them.
Is this test covered?
5ab7b0f to
ca1b3e7
Compare
|
@findepi please run the PR with secrets (I've slipped in a change which enables an existing product tests). |
|
/test-with-secrets sha=ca1b3e7f8795a7c59d60b2bb41f2aabc3ed65069 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/5850234042 |
|
I guess that the failure pt (default, suite-delta-lake-databricks73, ) has to do with the fact that |
|
Sent #18665 within repository. |
Databricks 7.3 is reaching on September 2023 end of support.
ca1b3e7 to
7cb65b2
Compare
|
Rebased on |
|
/test-with-secrets sha=7cb65b2d1451359ce579e76fa22fa5c507e6f0e4 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/6028127061 |
|
Updated mirror PR #18665 within the repository because the |
|
Unrelated test infra failure: |
Description
Databricks 7.3 is reaching on September 2023 end of support.
Release notes
(x) This is not user-visible or docs only and no release notes are required.