Skip to content

async and concurrently to process hudi table partitions in batches and create splits#18511

Closed
yx-keith wants to merge 4 commits intotrinodb:masterfrom
yx-keith:dev-406-hudi
Closed

async and concurrently to process hudi table partitions in batches and create splits#18511
yx-keith wants to merge 4 commits intotrinodb:masterfrom
yx-keith:dev-406-hudi

Conversation

@yx-keith
Copy link
Copy Markdown

@yx-keith yx-keith commented Aug 3, 2023

Description

With this PR, generate partition will happen in batches and concurrently, at the same time, generate splits asynchronous and concurrently.
can improve performance more than 5 times in trino 406 version in tpcds query with 1800 partitions

Additional context and related issues

fixs apache/hudi#7643
fixs #15564

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Aug 3, 2023
@yx-keith yx-keith requested a review from codope August 3, 2023 06:15
@github-actions github-actions bot added tests:hive hudi Hudi connector hive Hive connector labels Aug 3, 2023
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yx-keith I think shouldn't use .* throughout

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tooptoop4 thank you for pointing this out, I have fixed it

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can * be changed?

Copy link
Copy Markdown
Author

@yx-keith yx-keith Aug 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All * are changed now, I think

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can * be changed?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tooptoop4
thank you for reminder,I have fix it

@yx-keith
Copy link
Copy Markdown
Author

@tooptoop4 @codope @martint
Hi, there were bugs when running tpcds before, I have fixed it and improved by 14.67 times in tpcds query with 1800 partitions
can you help with review?

@electrum
Copy link
Copy Markdown
Member

electrum commented Nov 3, 2023

@yx-keith apologies for the delay. Can you rebase this PR?

@Amar1404
Copy link
Copy Markdown

Hi @yx-keith - When this will be merged.

@github-actions
Copy link
Copy Markdown

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Jan 11, 2024
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Jan 11, 2024

@yx-keith could you rebase this PR. Maybe @codope and @brandyml can help

@github-actions github-actions bot removed the stale label Jan 12, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 2, 2024

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Feb 2, 2024
@github-actions
Copy link
Copy Markdown

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@github-actions github-actions bot closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed hive Hive connector hudi Hudi connector stale

Development

Successfully merging this pull request may close these issues.

5 participants