Improve doc for Window functions#18507
Merged
mosabua merged 1 commit intotrinodb:masterfrom Nov 20, 2023
Merged
Conversation
Member
|
In your example you have an ORDER BY as part of the parameter for the array_agg function. The docs for the array_agg function clearly indicate that you just pass in a parameter .. not a statement snippet. The error message you see is probably misleading but this doc change is incorrect from all I can tell. Wdyt @kasiafi ? |
Contributor
Author
ea3aa7a to
94e08fc
Compare
94e08fc to
59fe33e
Compare
mosabua
approved these changes
Nov 20, 2023
Member
mosabua
left a comment
There was a problem hiding this comment.
Looks good after a minor tweak. Thank you and sorry for the delay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The doc should make it clear that the
ORDER BYclause in an aggregate function is not supported, if the aggregate function is used as a window function.For example, this works:
while this one fails:
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: