Reduce max task writer scaling defaults#18488
Merged
raunaqmorarka merged 2 commits intotrinodb:masterfrom Aug 2, 2023
Merged
Conversation
findepi
approved these changes
Aug 1, 2023
mosabua
requested changes
Aug 1, 2023
Member
mosabua
left a comment
mosabua
left a comment
There was a problem hiding this comment.
Please update the docs as well.
Member
Author
The original change did not update docs, so this revert already makes the code consistent with the current docs |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A high default for task.partitioned-writer-count and task.scale-writers.max-writer-count
can lead to queries running out of memory more often
Additional context and related issues
Defaults were increased in #18005 in 422
and found to cause previously working INSERTs to OOM
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: