Use tempto jdbc_jar for Delta query executor#18464
Merged
Conversation
findepi
reviewed
Jul 31, 2023
Member
There was a problem hiding this comment.
This will result in product test attempting to download the dependency at runtime, which may result in test flakiness.
We should download the dependency with maven, and thus utilize maven local cache.
Use maven-dependency-plugin copy goal
see eg io.trino.tests.product.launcher.env.environment.EnvMultinodeConfluentKafka#KAFKA_PROTOBUF_PROVIDER
ebyhr
force-pushed
the
ebi/delta-pt-jar-path
branch
from
6fd6987 to
f20daf9
Compare
ebyhr
force-pushed
the
ebi/delta-pt-jar-path
branch
from
f20daf9 to
5d80d8c
Compare
ebyhr
force-pushed
the
ebi/delta-pt-jar-path
branch
from
5d80d8c to
853685b
Compare
ebyhr
force-pushed
the
ebi/delta-pt-jar-path
branch
2 times, most recently
from
aeb8e7c to
a67f39c
Compare
ebyhr
force-pushed
the
ebi/delta-pt-jar-path
branch
2 times, most recently
from
5571a38 to
1addb06
Compare
ebyhr
force-pushed
the
ebi/delta-pt-jar-path
branch
from
1addb06 to
a9b1caf
Compare
findepi
approved these changes
Oct 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
(x) This is not user-visible or docs only and no release notes are required.