Switch error code to TABLE_NOT_FOUND if all columns filtered out#18451
Merged
findepi merged 1 commit intotrinodb:masterfrom Oct 20, 2023
Merged
Switch error code to TABLE_NOT_FOUND if all columns filtered out#18451findepi merged 1 commit intotrinodb:masterfrom
findepi merged 1 commit intotrinodb:masterfrom
Conversation
codyzwief
changed the title
findepi
reviewed
Oct 13, 2023
| List<Field> fields = filterInaccessibleFields(requestedFields); | ||
| if (fields.isEmpty()) { | ||
| if (!requestedFields.isEmpty()) { | ||
| throw semanticException(TABLE_NOT_FOUND, allColumns, "Relation not found or not allowed"); |
Member
There was a problem hiding this comment.
Or should this be AccessDeniedException?
Contributor
Author
There was a problem hiding this comment.
I went back and forth on this; I left it as not found to:
- Match current
COLUMN_NOT_FOUNDerror code - Leave room for columns to be filtered out not due to access control reasons
However I would be open to change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a minor change that modifies the error message when all columns in a select query get filtered out to be of
TABLE_NOT_FOUNDerror code instead ofCOLUMN_NOT_FOUND.Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: