Support CASCADE option for DROP SCHEMA statement in Hive#18320
Merged
Conversation
github-actions
bot
added
tests:hive
iceberg
Member
Author
|
CI hit #18322 |
findinpath
reviewed
Jul 18, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetastoreClosure.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jul 18, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/file/FileHiveMetastore.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jul 18, 2023
plugin/trino-hive/src/test/java/io/trino/plugin/hive/BaseTestHiveOnDataLake.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jul 18, 2023
plugin/trino-hive/src/test/java/io/trino/plugin/hive/BaseTestHiveOnDataLake.java
Outdated
Show resolved
Hide resolved
Contributor
|
My open question from looking at this PR is how should we deal with DROP on schemas containing external tables. |
ebyhr
force-pushed
the
ebi/hive-drop-schema-cascade
branch
from
31f509f to
7e792c6
Compare
findinpath
reviewed
Jul 22, 2023
.../trino-hive/src/main/java/io/trino/plugin/hive/metastore/SemiTransactionalHiveMetastore.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/hive-drop-schema-cascade
branch
from
7e792c6 to
177d9d6
Compare
ebyhr
force-pushed
the
ebi/hive-drop-schema-cascade
branch
from
177d9d6 to
8675ec2
Compare
findinpath
approved these changes
Aug 22, 2023
Praveen2112
reviewed
Aug 22, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetadata.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/hive-drop-schema-cascade
branch
from
8675ec2 to
3574f71
Compare
Praveen2112
approved these changes
Aug 22, 2023
| @Test | ||
| public void testUnsupportedDropSchemaCascadeWithNonHiveTable() | ||
| { | ||
| String schemaName = "test_unsupported_drop_schema_cascade_" + randomNameSuffix(); |
Member
There was a problem hiding this comment.
Can we add a hive tables to ensure it is also no dropped ?
Member
Author
There was a problem hiding this comment.
The ordering when dropping objects isn't ensured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Relates to #17649
Release notes
(x) Release notes are required, with the following suggested text: