Skip to content

Avoid running expensive INSERT to assert on the plan and stats calculation fixes#18314

Merged
findepi merged 6 commits intotrinodb:masterfrom
findepi:findepi/avoid-running-expensive-insert-to-assert-on-the-plan-0e9ca9
Jul 18, 2023
Merged

Avoid running expensive INSERT to assert on the plan and stats calculation fixes#18314
findepi merged 6 commits intotrinodb:masterfrom
findepi:findepi/avoid-running-expensive-insert-to-assert-on-the-plan-0e9ca9

Conversation

@findepi
Copy link
Member

@findepi findepi commented Jul 17, 2023 •
edited
Loading

Speed up testWriteTaskParallelismSessionProperty for JDBC connectors.

fixes #18328
fixes #18330

# release notes - based on issues being closed

@findepi findepi added test no-release-notes This pull request does not require release notes entry labels Jul 17, 2023
@cla-bot cla-bot bot added the cla-signed label Jul 17, 2023
@findepi findepi mentioned this pull request Jul 17, 2023
Merged
@findepi findepi force-pushed the findepi/avoid-running-expensive-insert-to-assert-on-the-plan-0e9ca9 branch from f6e01cc to 735be1c Compare July 17, 2023 15:15
@findepi findepi marked this pull request as draft July 17, 2023 15:17
@findepi findepi force-pushed the findepi/avoid-running-expensive-insert-to-assert-on-the-plan-0e9ca9 branch from 735be1c to 5e578e4 Compare July 17, 2023 15:32
@findepi findepi marked this pull request as ready for review July 17, 2023 15:32
@findepi
Copy link
Member Author

findepi commented Jul 17, 2023

/test-with-secrets sha=5e578e4a56e457fd298a77237b08c14fbe6c9c4b

@github-actions
Copy link

github-actions bot commented Jul 17, 2023 •
edited
Loading

The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/5577729017

@findepi findepi force-pushed the findepi/avoid-running-expensive-insert-to-assert-on-the-plan-0e9ca9 branch from 5e578e4 to 97bc649 Compare July 18, 2023 08:29
@findepi
Copy link
Member Author

findepi commented Jul 18, 2023

The change uncovered #18328

@findepi
Copy link
Member Author

findepi commented Jul 18, 2023

The change uncovered #18330

findepi added 6 commits July 18, 2023 16:34
@findepi
Fix Iceberg stats failure when predicate on $path of $file_modified_time
978250a
@findepi
Fix stats calculator failure in x IN (NULL, ..) case
0eeab9b
@findepi
Avoid executing in DistributedQueryRunner.createPlan
c4b947b
@findepi
Avoid running expensive INSERT to assert on the plan
630c3aa 
Speed up `testWriteTaskParallelismSessionProperty` for JDBC connectors.
@findepi
Remove unused method
7452d4d
@findepi
Fix test determinism
8454703 
Replace `PlanNodeSearcher.findFirst` with
`PlanNodeSearcher.findOnlyElement`. Test does not expect multiple
matching plan nodes.
@findepi findepi force-pushed the findepi/avoid-running-expensive-insert-to-assert-on-the-plan-0e9ca9 branch from 97bc649 to 8454703 Compare July 18, 2023 15:20
@findepi findepi changed the title Avoid running expensive INSERT to assert on the plan Avoid running expensive INSERT to assert on the plan and stats calculation fixes Jul 18, 2023
@github-actions github-actions bot added the iceberg Iceberg connector label Jul 18, 2023
@findepi findepi removed the no-release-notes This pull request does not require release notes entry label Jul 18, 2023
@findepi
Copy link
Member Author

findepi commented Jul 18, 2023

cc @sopel39 @losipiuk @martint for stats calculator fixes

@findepi findepi merged commit cd60b26 into trinodb:master Jul 18, 2023
@findepi findepi deleted the findepi/avoid-running-expensive-insert-to-assert-on-the-plan-0e9ca9 branch July 18, 2023 18:58
@github-actions github-actions bot added this to the 423 milestone Jul 18, 2023
@colebow colebow mentioned this pull request Aug 2, 2023
Merged
@findepi findepi mentioned this pull request Apr 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wendigo wendigo wendigo approved these changes

@kokosing kokosing Awaiting requested review from kokosing

@hashhar hashhar Awaiting requested review from hashhar

+1 more reviewer

@anusudarsan anusudarsan anusudarsan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed iceberg Iceberg connector test

Milestone

423

Development

Successfully merging this pull request may close these issues.

Stats calculation failure when explaining Iceberg query with $path column predicate Stats calculation failure for x IN (NULL) queries

3 participants

@findepi @wendigo @anusudarsan