Skip to content

[WIP] Expanded Support for Reading Short Decimal Column Reader with Extended TypeLength #18312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
UrvashiDang354 wants to merge 1 commit into from
Closed

[WIP] Expanded Support for Reading Short Decimal Column Reader with Extended TypeLength #18312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/trino-parquet/src/main/java/io/trino/parquet/reader/ShortDecimalColumnReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
import static io.trino.spi.type.TinyintType.TINYINT;
import static java.lang.String.format;
import static java.util.Objects.requireNonNull;
import static org.apache.parquet.schema.PrimitiveType.PrimitiveTypeName.FIXED_LEN_BYTE_ARRAY;
import static org.apache.parquet.schema.PrimitiveType.PrimitiveTypeName.INT32;
import static org.apache.parquet.schema.PrimitiveType.PrimitiveTypeName.INT64;

Expand All @@ -46,7 +47,9 @@ public class ShortDecimalColumnReader
super(field);
this.parquetDecimalType = requireNonNull(parquetDecimalType, "parquetDecimalType is null");
int typeLength = field.getDescriptor().getPrimitiveType().getTypeLength();
checkArgument(typeLength <= 16, "Type length %s should be <= 16 for short decimal column %s", typeLength, field.getDescriptor());
checkArgument(!(field.getDescriptor().getPrimitiveType().getPrimitiveTypeName() == FIXED_LEN_BYTE_ARRAY && typeLength > 16),
String.format("For the short decimal column %s, the type length %s should be at most %s",
field.getDescriptor(), typeLength, 16));
}

@Override
Expand Down