Change TaskId.fullId creation to mitigate probable JDK bug#18293
Merged
wendigo merged 2 commits intotrinodb:masterfrom Aug 23, 2023
Merged
Change TaskId.fullId creation to mitigate probable JDK bug#18293wendigo merged 2 commits intotrinodb:masterfrom
wendigo merged 2 commits intotrinodb:masterfrom
Conversation
martint
approved these changes
Jul 14, 2023
Member
martint
left a comment
martint
left a comment
There was a problem hiding this comment.
We may also need to run with CompactStrings disabled, since we don't know where else the bug may manifest.
Contributor
Author
|
It passed the tests for both JDK 20 and 21-e. I don’t know whether disabling CompactStrings wouldn’t have performance penalty. Do you think that this is necessary @martint ? I’d wait for the response to the JDK bug that I’ve reported |
This is suppose to mitigate trinodb#18272 when running on JDK 20 and 21-ea with -XX:+CompactStrings enabled. The bug report was submitted to JDK and we are waiting for triage.
wendigo
force-pushed
the
serafin/mitigiate-18272
branch
from
e25c4bf to
241593c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is suppose to mitigate #18272 when running on JDK 20 and 21-ea with
-XX:+CompactStringsenabled (the default).The bug report was submitted to JDK and we are waiting for triage.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: