Remove legacy Hive readers and writers#18241
Merged
electrum merged 12 commits intotrinodb:masterfrom Sep 6, 2023
Merged
Conversation
df7e9d5 to
7de468b
Compare
6e00005 to
b3dba79
Compare
...rino-hive/src/test/java/io/trino/plugin/hive/TestParquetPageSkippingWithOptimizedReader.java
Outdated
Show resolved
Hide resolved
5bcb6cf to
24cbba5
Compare
ecd6431 to
490b88e
Compare
490b88e to
815723f
Compare
|
Ihave two questions, Will the s3 select pushdown feature come back ? Will s3 select pushdown feature support parquet file pushdown? |
Member
Author
|
@awakeljw We have no plans to reimplement S3 Select. For Parquet, the results are returned as CSV or JSON, which is why it was never implemented in Trino. The feature introduces significant complexity in Trino and only benefits textfile formats. Additionally, the pricing model for S3 Select seems to put it at a disadvantage compared to simply increasing compute on the Trino side. Thus, we don't believe it is worth the complexity and maintenance burden. |
This was referenced Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR will be merged once we have confidence in the new readers and writers.
Release notes
(x) Release notes are required, with the following suggested text: