Skip to content

add hostnameInCertificate to JDBC Client Docs#18218

Merged
mosabua merged 2 commits intotrinodb:masterfrom
thepetlyon:hostnameInCertificate
Jul 11, 2023
Merged

add hostnameInCertificate to JDBC Client Docs#18218
mosabua merged 2 commits intotrinodb:masterfrom
thepetlyon:hostnameInCertificate

Conversation

@thepetlyon
Copy link
Copy Markdown
Contributor

Description

add hostnameInCertificate to JDBC Client Docs.

Additional context and related issues

Adding changes pushed in #17939.

Release notes

(X) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jul 10, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Peter Lyons.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@thepetlyon thepetlyon marked this pull request as draft July 10, 2023 21:08
@thepetlyon thepetlyon force-pushed the hostnameInCertificate branch from 04ec46f to ebf4ea1 Compare July 10, 2023 21:09
@cla-bot cla-bot bot added the cla-signed label Jul 10, 2023
@thepetlyon thepetlyon force-pushed the hostnameInCertificate branch from ebf4ea1 to bc93035 Compare July 10, 2023 21:10
@thepetlyon thepetlyon marked this pull request as ready for review July 10, 2023 21:10
@thepetlyon thepetlyon requested review from kokosing and mosabua July 10, 2023 21:10
@github-actions github-actions bot added the docs label Jul 10, 2023
Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for sending this. Please update and then I am happy to merge.

Co-authored-by: Manfred Moser <manfred@simpligility.ca>
@thepetlyon
Copy link
Copy Markdown
Contributor Author

Thank you for sending this. Please update and then I am happy to merge.

Committed! Thank you!

@mosabua mosabua merged commit 4b58c80 into trinodb:master Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants