Skip to content

Minor improvements to FTE scheduling #18144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
losipiuk merged 2 commits into from
Jul 6, 2023
Merged

Minor improvements to FTE scheduling #18144

losipiuk merged 2 commits into from
Jul 6, 2023

Conversation

@linzebing
Copy link
Member

@linzebing linzebing commented Jul 5, 2023 •
edited
Loading

Description

  1. Simple pruning to avoid resorting and re-registration if optimized plan is the same as old plan
  2. Change adaptive task sizing growth factor to 1.26, which is a better default after Round targetPartitionSizeInBytes to a multiple of minTargetPartitionSizeInBytes #17834

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Jul 5, 2023
@linzebing linzebing requested review from arhimondr and losipiuk July 5, 2023 20:31
@github-actions github-actions bot added the docs label Jul 5, 2023
@losipiuk losipiuk force-pushed the linzebing/fte-optimizePlan-improve branch from 9879311 to 6cb2bda Compare July 6, 2023 05:44
@losipiuk
Copy link
Member

losipiuk commented Jul 6, 2023

I fixed failing test

@losipiuk losipiuk merged commit 73baa18 into trinodb:master Jul 6, 2023
@github-actions github-actions bot added this to the 421 milestone Jul 6, 2023
@colebow colebow mentioned this pull request Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@losipiuk losipiuk losipiuk approved these changes

+1 more reviewer

@arhimondr arhimondr arhimondr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed docs

Milestone

421

Development

Successfully merging this pull request may close these issues.

3 participants

@linzebing @losipiuk @arhimondr