Support check constraints for MERGE#18137
Merged
martint merged 3 commits intotrinodb:masterfrom Aug 23, 2023
pajaks:pajaks/constraints_merge
Merged
Support check constraints for MERGE#18137martint merged 3 commits intotrinodb:masterfrom pajaks:pajaks/constraints_merge
martint merged 3 commits intotrinodb:masterfrom
pajaks:pajaks/constraints_merge
Conversation
Contributor
This seems to be more related to the engine. |
Member
Author
|
Not ready for review yet (lots of failures in CI is related to this changes) |
Member
Author
Changes in Delta code are not needed to MERGE. Added product test to ensure it's working properly. |
ebyhr
reviewed
Jul 11, 2023
core/trino-main/src/test/java/io/trino/sql/query/TestCheckConstraint.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/query/TestCheckConstraint.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jul 11, 2023
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jul 11, 2023
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jul 11, 2023
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java
Outdated
Show resolved
Hide resolved
martint
reviewed
Jul 11, 2023
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jul 11, 2023
core/trino-main/src/test/java/io/trino/sql/query/TestCheckConstraint.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jul 12, 2023
...rc/main/java/io/trino/tests/product/deltalake/TestDeltaLakeCheckConstraintCompatibility.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jul 18, 2023
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jul 18, 2023
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jul 18, 2023
core/trino-main/src/test/java/io/trino/sql/query/TestCheckConstraint.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jul 18, 2023
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java
Outdated
Show resolved
Hide resolved
Member
|
@martint Please take another look. |
Member
Author
|
Rebased to remove conflicts |
martint
reviewed
Aug 22, 2023
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/QueryPlanner.java
Outdated
Show resolved
Hide resolved
Changes in DeltaLake tests are included here as changes in engine enables functionality in Delta connector implicitly
martint
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15411
Release notes
(x) Release notes are required, with the following suggested text: