Simplify DeltaLakeMetadata with new model class#18133
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Mar 1, 2024
Merged
Conversation
findepi
reviewed
Jul 5, 2023
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaTable.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jul 5, 2023
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/delta-refactoring
branch
from
7e3adb9 to
51f9dd2
Compare
ebyhr
force-pushed
the
ebi/delta-refactoring
branch
2 times, most recently
from
3a6ada1 to
93a6dc5
Compare
pajaks
reviewed
Jul 17, 2023
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/delta-refactoring
branch
from
93a6dc5 to
6f492d4
Compare
Member
Author
|
Just rebased on master without changes. |
Merged
ebyhr
force-pushed
the
ebi/delta-refactoring
branch
from
6f492d4 to
2c79f4c
Compare
pajaks
approved these changes
Aug 10, 2023
ebyhr
force-pushed
the
ebi/delta-refactoring
branch
from
2c79f4c to
cfcf446
Compare
Member
Author
|
I will rebase after #18423 |
ebyhr
force-pushed
the
ebi/delta-refactoring
branch
from
cfcf446 to
0871e5b
Compare
ebyhr
force-pushed
the
ebi/delta-refactoring
branch
from
0871e5b to
50e2dbd
Compare
findinpath
reviewed
Oct 22, 2023
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaTable.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaTable.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/delta-refactoring
branch
from
50e2dbd to
8513d22
Compare
ebyhr
force-pushed
the
ebi/delta-refactoring
branch
from
8513d22 to
2c9f7e0
Compare
ebyhr
force-pushed
the
ebi/delta-refactoring
branch
2 times, most recently
from
daec8b2 to
f25818e
Compare
ebyhr
added
the
no-release-notes
findinpath
reviewed
Feb 16, 2024
Contributor
findinpath
left a comment
findinpath
left a comment
There was a problem hiding this comment.
DeltaTable / DeltaLakeTable otherwise said an object representation of the JSON content from DeltaLakeSchemaSupport seems pretty appealing.
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaTable.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaTable.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaTable.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaTable.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/delta-refactoring
branch
4 times, most recently
from
a53ec16 to
17088c3
Compare
findinpath
approved these changes
Feb 19, 2024
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/delta-refactoring
branch
2 times, most recently
from
ecfab27 to
ae0d7cf
Compare
Member
Author
|
@findepi Could you please review this PR when you have time? |
findepi
approved these changes
Feb 22, 2024
Member
findepi
left a comment
findepi
left a comment
There was a problem hiding this comment.
skimmed. @alexjo2144 you may want to review this
alexjo2144
reviewed
Feb 29, 2024
Member
alexjo2144
left a comment
alexjo2144
left a comment
There was a problem hiding this comment.
Nice, this is way better 👍
One small comment
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/delta-refactoring
branch
from
ae0d7cf to
f5ce751
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The motivation comes from #18013. Currently, DeltaLakeMetadata class calls some
getColumn*(MetadataEntry)methods from several places. It's a little hard to use those methods correctly.It would be better to manage those information in a single place.