Fix Hive sorted write failure when user identity contains @ sign (v2)#18131
Merged
findepi merged 3 commits intotrinodb:masterfrom Jul 5, 2023
Merged
Fix Hive sorted write failure when user identity contains @ sign (v2)#18131findepi merged 3 commits intotrinodb:masterfrom
findepi merged 3 commits intotrinodb:masterfrom
Conversation
Locations look like URIs, so make more apparent similarities and differences in how Location and URI work.
findepi
force-pushed
the
findepi/fix-hive-sorted-2
branch
from
f998d82 to
504443c
Compare
Member
Author
|
pt (hdp3, suite-3, ) failure doesn't look related will re-run. edit: reported as #18134 |
losipiuk
approved these changes
Jul 5, 2023
It's common for staging path to contain `${USER}` placeholder and be on
local file system. When username contains an AT sign (`name@domain`),
the `setSchemeToFileIfAbsent` used to fail, because `Location` couldn't
parse e.g. `file:///tmp/user@example.com`, treating the `@` sign as
userInfo separator. The parsing logic (split by `@ first or split by `/`
first) was different than in the URI class. This commit makes them more
similar.
Member
Author
|
CI green (https://github.com/trinodb/trino/actions/runs/5458592625?pr=18131). Will add one more test case. |
findepi
force-pushed
the
findepi/fix-hive-sorted-2
branch
from
504443c to
c23752a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's common for staging path to contain
${USER}placeholder and be onlocal file system. When username contains an AT sign (
name@domain),the
setSchemeToFileIfAbsentused to fail, becauseLocationcouldn'tparse e.g.
file:///tmp/user@example.com, treating the@sign asuserInfo separator. The parsing logic (split by
@ first or split by/`first) was different than in the URI class. This PR makes them more
similar.
Fixes #18132