-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add thread-per-driver executor #18118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b661b11
Move stuck split test to a separate class
martint 1a47841
Remove unnecessary shared state in test
martint 5b9ab88
Migrate TestSqlTaskManager to JUnit
martint ade3ef5
Extract interface for TaskExecutor
martint b0bb00f
Remove unused field
martint 7d0a51a
Add missing driver failure signal
martint 82e2a6b
Add thread-per-driver executor
martint File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98 changes: 98 additions & 0 deletions
98
core/trino-main/src/main/java/io/trino/execution/executor/RunningSplitInfo.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| /* | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package io.trino.execution.executor; | ||
|
|
||
| import com.google.common.collect.ComparisonChain; | ||
| import io.trino.execution.TaskId; | ||
|
|
||
| import java.util.function.Supplier; | ||
|
|
||
| import static java.util.Objects.requireNonNull; | ||
|
|
||
| /** | ||
| * A class representing a split that is running on the TaskRunner. | ||
| * It has a Thread object that gets assigned while assigning the split | ||
| * to the taskRunner. However, when the TaskRunner moves to a different split, | ||
| * the thread stored here will not remain assigned to this split anymore. | ||
| */ | ||
| public class RunningSplitInfo | ||
| implements Comparable<RunningSplitInfo> | ||
| { | ||
| private final long startTime; | ||
| private final String threadId; | ||
| private final Thread thread; | ||
| private boolean printed; | ||
| private final TaskId taskId; | ||
| private final Supplier<String> splitInfo; | ||
|
|
||
| public RunningSplitInfo(long startTime, String threadId, Thread thread, TaskId taskId, Supplier<String> splitInfo) | ||
| { | ||
| this.startTime = startTime; | ||
| this.threadId = requireNonNull(threadId, "threadId is null"); | ||
| this.thread = requireNonNull(thread, "thread is null"); | ||
| this.taskId = requireNonNull(taskId, "taskId is null"); | ||
| this.splitInfo = requireNonNull(splitInfo, "split is null"); | ||
| this.printed = false; | ||
|
martint marked this conversation as resolved.
Outdated
|
||
| } | ||
|
|
||
| public long getStartTime() | ||
| { | ||
| return startTime; | ||
| } | ||
|
|
||
| public String getThreadId() | ||
| { | ||
| return threadId; | ||
| } | ||
|
|
||
| public Thread getThread() | ||
| { | ||
| return thread; | ||
| } | ||
|
|
||
| public TaskId getTaskId() | ||
| { | ||
| return taskId; | ||
| } | ||
|
|
||
| /** | ||
| * {@link PrioritizedSplitRunner#getInfo()} provides runtime statistics for the split (such as total cpu utilization so far). | ||
| * A value returned from this method changes over time and cannot be cached as a field of {@link RunningSplitInfo}. | ||
| * | ||
| * @return Formatted string containing runtime statistics for the split. | ||
| */ | ||
| public String getSplitInfo() | ||
| { | ||
| return splitInfo.get(); | ||
| } | ||
|
|
||
| public boolean isPrinted() | ||
| { | ||
| return printed; | ||
| } | ||
|
|
||
| public void setPrinted() | ||
| { | ||
| printed = true; | ||
| } | ||
|
|
||
| @Override | ||
| public int compareTo(RunningSplitInfo o) | ||
| { | ||
| return ComparisonChain.start() | ||
| .compare(startTime, o.getStartTime()) | ||
| .compare(threadId, o.getThreadId()) | ||
| .result(); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.