Add exception guards for scheduleWithFixedDelay#18085
Merged
losipiuk merged 1 commit intotrinodb:masterfrom Jul 4, 2023
Merged
Add exception guards for scheduleWithFixedDelay#18085losipiuk merged 1 commit intotrinodb:masterfrom
losipiuk merged 1 commit intotrinodb:masterfrom
Conversation
findepi
approved these changes
Jul 4, 2023
core/trino-main/src/main/java/io/trino/dispatcher/QueuedStatementResource.java
Outdated
Show resolved
Hide resolved
There were some remaining routines called via scheduleWithFixedDelay which were not guarded with try...catch all clause. It is important to have such clause so routine is not silently unscheduled in case of unexpected error.
losipiuk
force-pushed
the
lo/catch-task-info-fetcher
branch
from
f17b50c to
8927628
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some remaining routines called via scheduleWithFixedDelay which were not guarded with try...catch all clause. It is important to have such clause so routine is not silently unscheduled in case of unexpected error.
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: