Skip to content

Enable Error Prone check: OrphanedFormatString #18080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
electrum merged 2 commits into from
Jun 30, 2023
Merged

Enable Error Prone check: OrphanedFormatString #18080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce26514
Fix orphaned format strings
electrum Jun 29, 2023
6d11e59
Enable Error Prone check: OrphanedFormatString
electrum Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...no-accumulo/src/main/java/io/trino/plugin/accumulo/metadata/ZooKeeperMetadataManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,7 @@ private boolean isAccumuloTable(SchemaTableName tableName)
return false;
}

throw new TrinoException(ZOOKEEPER_ERROR, "Error checking if path %s is an AccumuloTable object", e);
throw new TrinoException(ZOOKEEPER_ERROR, "Error checking if path is an AccumuloTable object", e);
}
}

Expand Down
13 changes: 6 additions & 7 deletions plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveSplitManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@
import static com.google.common.base.MoreObjects.firstNonNull;
import static com.google.common.base.Preconditions.checkArgument;
import static com.google.common.base.Strings.isNullOrEmpty;
import static com.google.common.base.Verify.verify;
import static com.google.common.collect.ImmutableList.toImmutableList;
import static com.google.common.collect.Iterators.peekingIterator;
import static com.google.common.collect.Iterators.singletonIterator;
Expand Down Expand Up @@ -225,13 +226,11 @@ public ConnectorSplitSource getSplits(
// validate bucket bucketed execution
Optional<HiveBucketHandle> bucketHandle = hiveTable.getBucketHandle();

if (bucketHandle.isPresent()) {
if (bucketHandle.get().getReadBucketCount() > bucketHandle.get().getTableBucketCount()) {
throw new TrinoException(
GENERIC_INTERNAL_ERROR,
"readBucketCount (%s) is greater than the tableBucketCount (%s) which generally points to an issue in plan generation");
}
}
bucketHandle.ifPresent(bucketing ->
verify(bucketing.getReadBucketCount() <= bucketing.getTableBucketCount(),
"readBucketCount (%s) is greater than the tableBucketCount (%s) which generally points to an issue in plan generation",
bucketing.getReadBucketCount(),
bucketing.getTableBucketCount()));

// get partitions
Iterator<HivePartition> partitions = partitionManager.getPartitions(metastore, hiveTable);
Expand Down
1 change: 1 addition & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2369,6 +2369,7 @@
-Xep:NullOptional:ERROR \
-Xep:ObjectToString:ERROR \
-Xep:OptionalNotPresent:ERROR \
-Xep:OrphanedFormatString:ERROR \
-Xep:Overrides:ERROR \
<!-- flags List fields even if initialized with ImmutableList -->
-Xep:PreferredInterfaceType:OFF \
Expand Down