Replace TypedSet with new BlockSet#18034
Merged
dain merged 1 commit intotrinodb:masterfrom Jun 26, 2023
Merged
Conversation
Member
|
Can we use BlockSet instead of TypedSet in DynamicFilterSourceOperator as well ? We have a JMH benchmark BenchmarkDynamicFilterSourceOperator available to see if it improves perf. |
electrum
approved these changes
Jun 26, 2023
core/trino-main/src/main/java/io/trino/operator/scalar/ArrayExceptFunction.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/scalar/BlockSet.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/scalar/BlockSet.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/scalar/BlockSet.java
Outdated
Show resolved
Hide resolved
Member
Author
No, but I have a branch that rewrites that part that I'll be putting up for review soon |
electrum
approved these changes
Jun 26, 2023
core/trino-main/src/main/java/io/trino/operator/scalar/BlockSet.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/scalar/BlockSet.java
Outdated
Show resolved
Hide resolved
BlockSet does not copy values out of the input blocks, and instead a direct reference is kept. This improves performance for cases where the set is a temporary data structure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BlockSetdoes not copy values out of the input blocks, and instead a direct reference is kept. This improves performance for cases where the set is a temporary data structure.Most uses of
TypedSetcan be replaced withBlockSet, because the set is used in a single lexical scope.Release notes
(x) This is not user-visible or docs only and no release notes are required.