Reduce query lock contention#18023
Merged
pettyjamesm merged 2 commits intotrinodb:masterfrom Jun 28, 2023
Merged
Conversation
Returns a consolidated QueryResultsResponse instead of just QueryResults from Query#waitForResults so that the HTTP response threads don't need to needlessly resynchronize on the Query instance to determine which ProtocolHeaders should be set on the response.
Avoids registering wrapping timeout callbacks and potential lock contentionn in Query#waitForResults by checking ListenableFuture#isDone() before adding the timeout and reduces the extent of the synchronized section to avoid potentially contending with the callback thread.
pettyjamesm
force-pushed
the
reduce-query-lock-contention
branch
from
2aa6f9b to
54f950d
Compare
arhimondr
approved these changes
Jun 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reduces sources of lock contention associated with
Query#waitForResultsand it's usage byExecutingStatementResource, largely by passing the additional protocol header fields along with theQueryResultspayload in a single record class.Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: