Fix 'Illegal instant due to time zone offset transition'#18010
Merged
kokosing merged 2 commits intotrinodb:masterfrom Jul 3, 2023
Merged
Fix 'Illegal instant due to time zone offset transition'#18010kokosing merged 2 commits intotrinodb:masterfrom
kokosing merged 2 commits intotrinodb:masterfrom
Conversation
kokosing
reviewed
Jun 23, 2023
client/trino-jdbc/src/test/java/io/trino/jdbc/BaseTestJdbcResultSet.java
Outdated
Show resolved
Hide resolved
client/trino-jdbc/src/main/java/io/trino/jdbc/AbstractTrinoResultSet.java
Outdated
Show resolved
Hide resolved
client/trino-jdbc/src/main/java/io/trino/jdbc/AbstractTrinoResultSet.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/test-illegal-instant-for-date
branch
2 times, most recently
from
de17e30 to
a3efb92
Compare
kokosing
approved these changes
Jun 26, 2023
client/trino-jdbc/src/main/java/io/trino/jdbc/AbstractTrinoResultSet.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/test-illegal-instant-for-date
branch
from
a3efb92 to
58735c8
Compare
findepi
reviewed
Jul 3, 2023
| catch (IllegalInstantException ignored) { | ||
| // https://joda-time.sourceforge.net/faq.html#illegalinstant | ||
| LocalDate localDate = DATE_FORMATTER.parseLocalDate(String.valueOf(value)); | ||
| return new Date(localDate.toDateTimeAtStartOfDay(localTimeZone).getMillis()); |
Member
There was a problem hiding this comment.
-
shouldn't this be done only if
millis >= START_OF_MODERN_ERA_SECONDS * MILLISECONDS_PER_SECOND?
the code block below is supposed to be handling!(millis >= START_OF_MODERN_ERA_SECONDS * MILLISECONDS_PER_SECOND)cases, but it's no longer the case -
why do we parse with two different ways? can't we use
DATE_FORMATTER.parseLocalDatealways?
if there is a good reason for this, there should be a code comment explaining it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6242
Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: