Update AWS SDK v2 to 2.20.89#17989
Merged
electrum merged 2 commits intotrinodb:masterfrom Jun 21, 2023
Merged
Conversation
Contributor
|
@trinodb/maintainers pls run the PR with secrets |
losipiuk
reviewed
Jun 21, 2023
Member
There was a problem hiding this comment.
Now when you changed fromByteBufferUnsafe it should be fine.
@linzebing PTAL.
losipiuk
previously requested changes
Jun 21, 2023
Member
losipiuk
left a comment
There was a problem hiding this comment.
Restore ByteBufferAsyncRequestBody.
BTW: Even if we wanted to drop it - it should be separate commit - not SDK version update
Contributor
Author
485901d to
4776e1d
Compare
Contributor
Author
|
@losipiuk extracted to separate commit |
Contributor
Author
|
@losipiuk I think this part is relevant: |
Contributor
Author
|
There is also pending PR which seems relevant here: aws/aws-sdk-java-v2#4096: |
It was introduced in SDK v2 2.20.84 by aws/aws-sdk-java-v2#3925
4776e1d to
87e9678
Compare
Member
|
/test-with-secrets 7d308de |
linzebing
approved these changes
Jun 21, 2023
Member
|
/test-with-secrets sha=7d308deed56c6cc619d16b1b7a18a7713972e586 |
Member
|
Looks like we need to squash the commits, since the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.