Conversation
findepi
added
test
no-release-notes
martint
approved these changes
Jun 20, 2023
ebyhr
approved these changes
Jun 20, 2023
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Looks good except for CI failure:
Error: Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project trino-product-tests: Compilation failure: Compilation failure:
Error: /home/runner/work/trino/trino/testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveMerge.java:[377,17] reference to assertThat is ambiguous
Error: both method <T>assertThat(org.assertj.core.api.AssertProvider<T>) in org.assertj.core.api.Assertions and method <T>assertThat(T) in org.assertj.core.api.Assertions match
Error: /home/runner/work/trino/trino/testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveMerge.java:[379,25] cannot find symbol
Error: symbol: method failsWithMessage(java.lang.String)
Error: location: class io.trino.tempto.query.QueryResult
Error: /home/runner/work/trino/trino/testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveMerge.java:[665,13] reference to assertThat is ambiguous
Error: both method <T>assertThat(org.assertj.core.api.AssertProvider<T>) in org.assertj.core.api.Assertions and method <T>assertThat(T) in org.assertj.core.api.Assertions match
Error: /home/runner/work/trino/trino/testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveMerge.java:[669,21] cannot find symbol
Error: symbol: method failsWithMessage(java.lang.String)
Error: location: class io.trino.tempto.query.QueryResult
findepi
force-pushed
the
findepi/replace-queryassert-assertthat-with-assertj-s-assertthat-82c73e
branch
from
4365b14 to
9c48f9f
Compare
`assertQueryFailure` should be used instead, per deprecation note.
Move off deprecated `QueryAssert.assertThat` to `Assertions.assertThat`.
findepi
force-pushed
the
findepi/replace-queryassert-assertthat-with-assertj-s-assertthat-82c73e
branch
from
9c48f9f to
e9391c6
Compare
findepi
deleted the
findepi/replace-queryassert-assertthat-with-assertj-s-assertthat-82c73e
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move off deprecated
QueryAssert.assertThattoAssertions.assertThat.Fixes #17690