Merged
Conversation
findepi
force-pushed
the
findepi/fix-forked-pr-ci
branch
from
b08aa5a to
86d845e
Compare
findepi
requested review from
ebyhr and
findinpath
and removed request for
ebyhr
findinpath
approved these changes
Jun 20, 2023
findinpath
reviewed
Jun 20, 2023
Contributor
There was a problem hiding this comment.
Just for context, EnvSinglenodeHudi uses the same strategy as you did here:
ebyhr
approved these changes
Jun 20, 2023
...src/main/java/io/trino/tests/product/launcher/env/environment/EnvSinglenodeDeltaLakeOss.java
Outdated
Show resolved
Hide resolved
`EnvSinglenodeDeltaLakeOss` was not working when PR's CI build is triggered from the fork. The secrets and variables are not present, and this resulted in `S3_BUCKET` env variable being defined but empty. However, the environment doesn't need to be parameterized with the bucket name at all.
findepi
force-pushed
the
findepi/fix-forked-pr-ci
branch
from
86d845e to
99c5951
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EnvSinglenodeDeltaLakeOsswas not working when PR's CI build istriggered from the fork. The secrets and variables are not present, and
this resulted in
S3_BUCKETenv variable being defined but empty.However, the environment doesn't need to be parameterized with the
bucket name at all.