Prevent Hudi from accessing system tables of non-Hudi tables and other Hudi metadata refactor#17955
Merged
Prevent Hudi from accessing system tables of non-Hudi tables and other Hudi metadata refactor#17955
Conversation
findepi
added
no-release-notes
findepi
requested review from
anusudarsan,
codope,
ebyhr,
electrum,
findinpath and
homar
findepi
force-pushed
the
findepi/hudixies
branch
3 times, most recently
from
93a840c to
090672d
Compare
findinpath
reviewed
Jun 20, 2023
...-product-tests/src/main/java/io/trino/tests/product/hudi/TestHudiHiveViewsCompatibility.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jun 20, 2023
plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiMetadata.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jun 20, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/HiveUtil.java
Outdated
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/hudixies
branch
3 times, most recently
from
4e230a5 to
ccb5bd0
Compare
findinpath
reviewed
Jun 20, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/HiveUtil.java
Outdated
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/hudixies
branch
from
ccb5bd0 to
cb75913
Compare
ebyhr
approved these changes
Jun 21, 2023
...-product-tests/src/main/java/io/trino/tests/product/hudi/TestHudiHiveViewsCompatibility.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/HiveUtil.java
Outdated
Show resolved
Hide resolved
plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/HudiMetadata.java
Outdated
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/hudixies
branch
from
cb75913 to
4dc69e3
Compare
This was referenced Jun 21, 2023
findepi
force-pushed
the
findepi/hudixies
branch
2 times, most recently
from
b208ec0 to
8396f43
Compare
Copy of `TestIcebergHiveTablesCompatibility`.
Make clearer we don't default to `true`.
And add TODO about $data system table.
This changes file metastore to support storage formats other than those described by Hive's `HiveStorageFormat` enum. This makes the implementation more suitable for testing other connectors, such as Hudi, which uses different storage formats. This resolves a TODO in the code.
In case of redirects between catalogs it's important to have unified view of the table type. Logically this splits `HudiUtil.isHudiTable` into - checking if table SHOULD BE hudi table (done by `HiveUtil.isHudiTable`, but without checking on-disk metadata) - checking if Hudi table has some metadata files, i.e. verifying the location (done by `hudiMetadataExists`, new method).
findepi
force-pushed
the
findepi/hudixies
branch
from
8396f43 to
77b57e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.