Skip to content

Update error-prone to 2.20.0#17941

Merged
mosabua merged 1 commit intotrinodb:masterfrom
wendigo:serafin/errorprone-jdk21
Jun 19, 2023
Merged

Update error-prone to 2.20.0#17941
mosabua merged 1 commit intotrinodb:masterfrom
wendigo:serafin/errorprone-jdk21

Conversation

@wendigo
Copy link
Copy Markdown
Contributor

@wendigo wendigo commented Jun 16, 2023

This is the first version supporting JDK 21

Description

Additional context and related issues

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Jun 16, 2023
@wendigo wendigo requested review from electrum and kokosing June 16, 2023 21:30
Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.

@wendigo
Copy link
Copy Markdown
Contributor Author

wendigo commented Jun 16, 2023

Locally it passed all the existing checks so there are no regressions.

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Jun 16, 2023

I will merge after CI passes, if desired

@wendigo
Copy link
Copy Markdown
Contributor Author

wendigo commented Jun 16, 2023

Please do @mosabua

@wendigo
Copy link
Copy Markdown
Contributor Author

wendigo commented Jun 16, 2023

@mosabua error-prone passed 🎉

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Jun 16, 2023

This looks okay to me. Can you confirm that the failure is unrelated @wendigo @martint ?

@wendigo
Copy link
Copy Markdown
Contributor Author

wendigo commented Jun 17, 2023

It is unrelated @mosabua

This is the first version supporting JDK 21
@wendigo wendigo force-pushed the serafin/errorprone-jdk21 branch from ad9d7ac to b990686 Compare June 17, 2023 20:34
@mosabua mosabua merged commit 5d14d6f into trinodb:master Jun 19, 2023
@github-actions github-actions bot added this to the 420 milestone Jun 19, 2023
@wendigo wendigo deleted the serafin/errorprone-jdk21 branch January 21, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants