Don't retry table metadata read when fails with ValidationException#17905
Merged
findepi merged 1 commit intotrinodb:masterfrom Jun 17, 2023
Merged
Don't retry table metadata read when fails with ValidationException#17905findepi merged 1 commit intotrinodb:masterfrom
findepi merged 1 commit intotrinodb:masterfrom
Conversation
f2e8fe0 to
a32ea5d
Compare
findinpath
reviewed
Jun 14, 2023
...no-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/AbstractIcebergTableOperations.java
Outdated
Show resolved
Hide resolved
a32ea5d to
7b18ab6
Compare
findinpath
reviewed
Jun 14, 2023
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
findinpath
reviewed
Jun 14, 2023
Contributor
There was a problem hiding this comment.
Do you happen to remember why we've added the test for the situation on the smoke test and not on BaseIcebergConnectorTest ?
I'm not necessarily requesting the checks to be done here as well.
Contributor
Author
There was a problem hiding this comment.
The tests are also added in BaseIcebergConnectorTest.
We wanted to verify the corrupted table against all catalogs and smoke test runs against all catalogs so added smoke test.
Contributor
Author
There was a problem hiding this comment.
One more reason to add smoke connector test is to verify against the different file systems.
findinpath
approved these changes
Jun 14, 2023
7b18ab6 to
37a5b97
Compare
findepi
approved these changes
Jun 16, 2023
...no-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/AbstractIcebergTableOperations.java
Outdated
Show resolved
Hide resolved
37a5b97 to
0a2022a
Compare
Contributor
Author
|
Thank you @findepi for the review. Addressed comments. |
findepi
approved these changes
Jun 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Don't retry table metadata read when fails with ValidationException