Make expected failure message self-explanatory#17903
Merged
Conversation
More close to how it was before 6729fed.
homar
approved these changes
Jun 14, 2023
ebyhr
approved these changes
Jun 14, 2023
electrum
reviewed
Jun 15, 2023
| allFilesFromCdfDirectory = getAllFilesFromCdfDirectory(tableName); | ||
| assertThat(allFilesFromCdfDirectory).hasSizeBetween(1, 2); | ||
| assertQueryFails("SELECT * FROM TABLE(system.table_changes('test_schema', '" + tableName + "', 2))", "Error opening Hive split .*"); | ||
| assertQueryFails("SELECT * FROM TABLE(system.table_changes('test_schema', '" + tableName + "', 2))", "Error opening Hive split.*/_change_data/.*The specified key does not exist.*"); |
Member
There was a problem hiding this comment.
This makes the message specific to S3.
Member
Author
There was a problem hiding this comment.
Good point! however, this test runs delta against s3, so i think it should be fine
Member
Author
|
CI #16315 |
findepi
deleted the
findepi/make-expected-failure-message-self-explanatory-2bb841
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More close to how it was before
6729fed.