Skip to content

Fix filterDataMappingSmokeTestData in ClickHouse #17877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Jun 14, 2023
Merged

Fix filterDataMappingSmokeTestData in ClickHouse #17877

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...rino-clickhouse/src/test/java/io/trino/plugin/clickhouse/TestClickHouseConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,8 +580,14 @@ protected Optional<DataMappingTestSetup> filterDataMappingSmokeTestData(DataMapp
return Optional.empty();

case "date":
// TODO (https://github.com/trinodb/trino/issues/7101) enable the test
return Optional.empty();
// The connector supports date type, but these values are unsupported in ClickHouse
// See BaseClickHouseTypeMapping for additional test coverage
if (dataMappingTestSetup.getSampleValueLiteral().equals("DATE '0001-01-01'") ||
dataMappingTestSetup.getSampleValueLiteral().equals("DATE '1582-10-05'") ||
dataMappingTestSetup.getHighValueLiteral().equals("DATE '9999-12-31'")) {
return Optional.empty();
}
return Optional.of(dataMappingTestSetup);

case "time":
case "time(6)":
Expand Down