Fix Iceberg scheduling failure due to dynamic filters#17871
Merged
findepi merged 1 commit intotrinodb:masterfrom Jun 13, 2023
Merged
Conversation
`IcebergSplitSource` could fail with `Split source must be finished before TableExecuteSplitsInfo is read` in the following scenario - `getNextBatch` called, initializing `fileScanIterator` and `fileTasksIterator`, but not consuming them fully - dynamic filters completes - `getNextBatch` called, crossing dynamic filter with table predicate, concluding it's none, calling `finish()` and returning NO_MORE_SPLITS_BATCH (signalling the source is finished) - `getTableExecuteSplitsInfo` is called by `SourcePartitionedScheduler`. The invocation fails because `isFinished` returns false, as `fileTasksIterator` isn't consumed.
losipiuk
approved these changes
Jun 13, 2023
raunaqmorarka
approved these changes
Jun 13, 2023
findepi
deleted the
findepi/fix-iceberg-scheduling-failure-due-to-dynamic-filters-c19c30
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IcebergSplitSourcecould fail withSplit source must be finished before TableExecuteSplitsInfo is readin the following scenariogetNextBatchcalled, initializingfileScanIteratorandfileTasksIterator, but not consuming them fullygetNextBatchcalled, crossing dynamic filter with table predicate, concluding it's none, callingfinish()and returning NO_MORE_SPLITS_BATCH (signalling the source is finished)getTableExecuteSplitsInfois called bySourcePartitionedScheduler. The invocation fails becauseisFinishedreturns false, asfileTasksIteratorisn't consumed.