Mark Oracle FailureRecovery tests as flaky#17860
Merged
losipiuk merged 1 commit intotrinodb:masterfrom Jun 14, 2023
Merged
Conversation
linzebing
approved these changes
Jun 12, 2023
hashhar
reviewed
Jun 13, 2023
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
can you stress this on CI before merging?
Looks good otherwise.
losipiuk
approved these changes
Jun 13, 2023
ebyhr
reviewed
Jun 13, 2023
plugin/trino-oracle/src/test/java/io/trino/plugin/oracle/BaseOracleFailureRecoveryTest.java
Outdated
Show resolved
Hide resolved
Member
|
@mwd410 I will speculatively mergi this one hoping it will save us some flakes. Please still stress test it on the side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We have been fighting with Oracle FailureRecovery tests, so until we identify the solution, we have decided to mark this test as flaky.
Additional context and related issues
Release notes
(X) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: