Skip to content

Support view column comments for DeltaLake#17829

Merged
ebyhr merged 2 commits intotrinodb:masterfrom
reswqa:view_comments
Jun 14, 2023
Merged

Support view column comments for DeltaLake#17829
ebyhr merged 2 commits intotrinodb:masterfrom
reswqa:view_comments

Conversation

@reswqa
Copy link
Copy Markdown
Contributor

@reswqa reswqa commented Jun 9, 2023 •
edited by ebyhr
Loading

Description

Support view column comments for DeltaLake

Additional context and related issues

This closes #17773

Release notes

(x) Release notes are required, with the following suggested text:

# Delta Lake
* Add support for commenting on view columns ({issue}`17773`)

@cla-bot cla-bot bot added the cla-signed label Jun 9, 2023
@github-actions github-actions bot added delta-lake Delta Lake connector hive Hive connector tests:hive labels Jun 9, 2023
ebyhr
ebyhr reviewed Jun 10, 2023
View reviewed changes
@github-actions github-actions bot added the iceberg Iceberg connector label Jun 10, 2023
@reswqa
Copy link
Copy Markdown
Contributor Author

reswqa commented Jun 10, 2023

Thanks @ebyhr for the patient review, I have updated this according to your comments.

There is only one comment that has not been resolved as I may not fully understand(see comment reply). Would you mind taking a look again in your free time, thanks~

@reswqa
Copy link
Copy Markdown
Contributor Author

reswqa commented Jun 12, 2023

Thanks for the review! I have updated this in the fix-up comments, PTAL again.

@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Jun 12, 2023 •
edited
Loading

Please update a product test. Please ignore this comment.

@reswqa
Copy link
Copy Markdown
Contributor Author

reswqa commented Jun 12, 2023

Please update a product test.

Sorry, I am not familiar with the code base. Could you please tell me which file it is in. Thanks!

@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Jun 12, 2023

Please take a look at testing/trino-product-tests/src/main/java/io/trino/tests/product/deltalake.

@reswqa reswqa force-pushed the view_comments branch 2 times, most recently from b4e6c11 to 3446761 Compare June 13, 2023 12:41
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Jun 13, 2023 •
edited
Loading

/test-with-secrets sha=3446761eb93cce77cc28773bc774a4c9409df152

https://github.com/trinodb/trino/actions/runs/5256401301/jobs/9497676164

@ebyhr ebyhr merged commit 1389deb into trinodb:master Jun 14, 2023
@github-actions github-actions bot added this to the 420 milestone Jun 14, 2023
@colebow colebow mentioned this pull request Jun 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebyhr ebyhr ebyhr approved these changes

Assignees

No one assigned

Labels

cla-signed delta-lake Delta Lake connector hive Hive connector iceberg Iceberg connector

Milestone

420

Development

Successfully merging this pull request may close these issues.

Add support for comments on VIEW columns for Delta Lake

2 participants

@reswqa @ebyhr