Do not run ok-to-test workflow on forks#17823
Merged
hashhar merged 1 commit intotrinodb:masterfrom Jun 9, 2023
Merged
Conversation
nineinchnick
approved these changes
Jun 9, 2023
Member
Author
Not really, the workflow will be invoked for every comment still but those fail-fast since they don't contain the trigger word. |
Member
Author
|
Actually, yes, it'll stop sending emails to people who add comments to their own fork or push to branches on their own fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Forks don't need this since they can just configure their own secrets. Also running this requires the app_id for the GitHub app we are using and sharing that with other repos is not safe anyway.
Release notes
(x) This is not user-visible or docs only and no release notes are required.
Fixes #17076