Skip to content

Reduce Spark log in Iceberg product tests#17818

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/iceberg-pt-log
Jun 10, 2023
Merged

Reduce Spark log in Iceberg product tests#17818
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/iceberg-pt-log

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Jun 9, 2023

Description

Reduce Spark log in Iceberg product tests
Relates to #16813

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Jun 9, 2023
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to extract a common/Spark similar to common/Minio? Then these configs will also go into common/spark.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense. Addressed only config file part in this PR>

Copy link
Copy Markdown
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ebyhr ebyhr force-pushed the ebi/iceberg-pt-log branch from b659ce7 to 26c10ca Compare June 10, 2023 03:29
@ebyhr ebyhr merged commit 3063140 into trinodb:master Jun 10, 2023
@ebyhr ebyhr deleted the ebi/iceberg-pt-log branch June 10, 2023 05:20
@github-actions github-actions bot added this to the 420 milestone Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants