Disallow the usage of invalid object names in HMS#17788
Merged
findepi merged 3 commits intotrinodb:masterfrom Jun 13, 2023
Merged
Disallow the usage of invalid object names in HMS#17788findepi merged 3 commits intotrinodb:masterfrom
findepi merged 3 commits intotrinodb:masterfrom
Conversation
findepi
approved these changes
Jun 7, 2023
hashhar
reviewed
Jun 7, 2023
Member
hashhar
left a comment
There was a problem hiding this comment.
what happens to reads on existing "invalid" names?
Contributor
Author
The existing object names, regardless whether they are valid or not valid (e.g. : "foo/bar" name) will be passed further to HMS as they are. |
Member
|
is |
Older version of HMS are more permissive in terms of names allowed for schemas/tables. Disallow directly in Trino object names that may eventually cause inaccuracies in the location of the schema/table saved in HMS.
aa47b5e to
2f41575
Compare
Contributor
Author
I think the failure is caused by the fact that this code depends on #17787 changes. Rebased on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Older version of HMS are more permissive in terms of names allowed for schemas/tables. Disallow directly in Trino object names that may eventually cause inaccuracies in the location of the schema/table saved in HMS.
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: