Configure HttpTransport for proxied GoogleCredentials#17783
Merged
hashhar merged 3 commits intotrinodb:masterfrom Jun 9, 2023
Merged
Configure HttpTransport for proxied GoogleCredentials#17783hashhar merged 3 commits intotrinodb:masterfrom
hashhar merged 3 commits intotrinodb:masterfrom
Conversation
wendigo
force-pushed
the
serafin/bq-credentials-proxy
branch
from
b075587 to
468ef64
Compare
wendigo
force-pushed
the
serafin/bq-credentials-proxy
branch
from
468ef64 to
c7be056
Compare
hashhar
reviewed
Jun 8, 2023
Member
There was a problem hiding this comment.
static one also needs the proxied transport. The service account key still requires to go talk to oauth2.googleapis.com to get an access token, the service account key itself is not an access token.
Contributor
Author
There was a problem hiding this comment.
Makes sense. Thanks for investigating that
Contributor
Author
There was a problem hiding this comment.
Done. I can indeed see extra proxied calls
Since this credentials could be obtained using proxied connections, it's not possible to validate those in a config class.
wendigo
force-pushed
the
serafin/bq-credentials-proxy
branch
from
c7be056 to
2d9a83b
Compare
hashhar
approved these changes
Jun 9, 2023
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
LGTM.
I'll merge this after a run with secrets finishes.
Member
|
/test-with-secrets sha=2d9a83b5d569dbade01ea4ba145c09557f54949e |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/5218792948 |
Member
|
CI hit #16803 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This would allow proxying communication with oauth2.googleapis.com when default credentials are used.