Improvements to numeric literals (underscores, hex, octal, binary)#17776
Merged
martint merged 2 commits intotrinodb:masterfrom Jun 8, 2023
Merged
Improvements to numeric literals (underscores, hex, octal, binary)#17776martint merged 2 commits intotrinodb:masterfrom
martint merged 2 commits intotrinodb:masterfrom
Conversation
f11da1a to
09145d6
Compare
dain
approved these changes
Jun 8, 2023
Member
There was a problem hiding this comment.
BTW, in general this syntax is dangerous because parse long supports a leading sign. It isn't a problem here because the grammar doesn't allow that, but I ran into code in Hive that did this and ended up supporting 0x-123
core/trino-parser/src/test/java/io/trino/sql/parser/TestSqlParser.java
Outdated
Show resolved
Hide resolved
core/trino-spi/src/test/java/io/trino/spi/type/TestDecimals.java
Outdated
Show resolved
Hide resolved
core/trino-parser/src/test/java/io/trino/sql/parser/TestSqlParser.java
Outdated
Show resolved
Hide resolved
09145d6 to
c2df597
Compare
As specified in SQL 2023:
<unsigned decimal integer> ::=
<digit> [ { [ <underscore> ] <digit> }... ]
As defined by SQL 2023
c2df597 to
7cba489
Compare
Member
|
@nineinchnick and @mosabua are working on docs for this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As specified in SQL 2023:
Release notes
(x) Release notes are required, with the following suggested text: