Skip to content

Rename table function SPI package#17774

Merged
martint merged 1 commit intotrinodb:masterfrom
martint:ptf-package
Jun 8, 2023
Merged

Rename table function SPI package#17774
martint merged 1 commit intotrinodb:masterfrom
martint:ptf-package

Conversation

@martint
Copy link
Copy Markdown
Member

@martint martint commented Jun 6, 2023

Avoid use of obscure abbreviations and move to a more appropriate location.

Release notes

(x) Release notes are required, with the following suggested text:

# SPI
* Move table function infrastructure to the `io.trino.spi.function.table` package.

@cla-bot cla-bot bot added the cla-signed label Jun 6, 2023
@github-actions github-actions bot added bigquery BigQuery connector delta-lake Delta Lake connector mongodb MongoDB connector labels Jun 6, 2023
@martint martint force-pushed the ptf-package branch 2 times, most recently from 9a69059 to c1e7b91 Compare June 6, 2023 21:19
@martint martint force-pushed the ptf-package branch 2 times, most recently from 043a9da to db09fa3 Compare June 6, 2023 23:36
@martint martint force-pushed the ptf-package branch 2 times, most recently from 2445d92 to f1c736a Compare June 7, 2023 14:24
Avoid use of obscure abbreviations and move to a more appropriate location.
@martint martint merged commit 96f9655 into trinodb:master Jun 8, 2023
@martint martint deleted the ptf-package branch June 8, 2023 15:34
@github-actions github-actions bot added this to the 420 milestone Jun 8, 2023
{
this.descriptor = requireNonNull(descriptor, "descriptor is null");
descriptor.ifPresent(descriptorValue -> checkArgument(
descriptor.ifPresent(descriptorValue -> Preconditions.checkArgument(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional change?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's not. It must have been an artifact introduced by IntelliJ when doing automatic package rename. Fix here: #17811

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bigquery BigQuery connector cla-signed delta-lake Delta Lake connector mongodb MongoDB connector

Development

Successfully merging this pull request may close these issues.

2 participants