Normalize OR and IN expressions referencing the same symbol as IN#17635
Merged
kokosing merged 1 commit intotrinodb:masterfrom Oct 26, 2023
chenjian2664:rewrite_in
Merged
Normalize OR and IN expressions referencing the same symbol as IN#17635kokosing merged 1 commit intotrinodb:masterfrom chenjian2664:rewrite_in
kokosing merged 1 commit intotrinodb:masterfrom
chenjian2664:rewrite_in
Conversation
kokosing
reviewed
May 25, 2023
...-main/src/main/java/io/trino/sql/planner/iterative/rule/NormalizeOrInExpressionRewriter.java
Outdated
Show resolved
Hide resolved
...-main/src/main/java/io/trino/sql/planner/iterative/rule/NormalizeOrInExpressionRewriter.java
Outdated
Show resolved
Hide resolved
kokosing
reviewed
Jun 13, 2023
core/trino-main/src/test/java/io/trino/sql/planner/iterative/rule/TestSimplifyExpressions.java
Outdated
Show resolved
Hide resolved
...-main/src/main/java/io/trino/sql/planner/iterative/rule/NormalizeOrInExpressionRewriter.java
Outdated
Show resolved
Hide resolved
...-main/src/main/java/io/trino/sql/planner/iterative/rule/NormalizeOrInExpressionRewriter.java
Outdated
Show resolved
Hide resolved
...-main/src/main/java/io/trino/sql/planner/iterative/rule/NormalizeOrInExpressionRewriter.java
Outdated
Show resolved
Hide resolved
...-main/src/main/java/io/trino/sql/planner/iterative/rule/NormalizeOrInExpressionRewriter.java
Outdated
Show resolved
Hide resolved
Praveen2112
reviewed
Jun 13, 2023
core/trino-main/src/main/java/io/trino/sql/planner/iterative/rule/SimplifyExpressions.java
Outdated
Show resolved
Hide resolved
...-main/src/main/java/io/trino/sql/planner/iterative/rule/NormalizeOrInExpressionRewriter.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@kokosing Would you like to have a look at this PR? |
kokosing
reviewed
Oct 18, 2023
...-main/src/main/java/io/trino/sql/planner/iterative/rule/NormalizeOrInExpressionRewriter.java
Outdated
Show resolved
Hide resolved
Member
Sure thing! |
kokosing
approved these changes
Oct 23, 2023
Contributor
Author
|
@kokosing Do you think we need to rename the |
Member
|
I would keep the existing name. |
Member
|
Thank you! Merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.