Skip to content

Remove duplicated method in DeltaLakeMetadata #17555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Jun 14, 2023
Merged

Remove duplicated method in DeltaLakeMetadata #17555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1640,7 +1640,7 @@ public void finishMerge(ConnectorSession session, ConnectorMergeTableHandle merg
List<DataFileInfo> cdcFiles = ImmutableList.copyOf(split.get(false));

if (mergeHandle.getInsertTableHandle().isRetriesEnabled()) {
cleanExtraOutputFilesForUpdate(session, Location.of(handle.getLocation()), allFiles);
cleanExtraOutputFiles(session, Location.of(handle.getLocation()), allFiles);
}

Optional<Long> checkpointInterval = handle.getMetadataEntry().getCheckpointInterval();
Expand Down Expand Up @@ -2816,15 +2816,6 @@ private void cleanExtraOutputFiles(ConnectorSession session, Location baseLocati
cleanExtraOutputFiles(session, writtenFilePaths);
Comment thread
pajaks marked this conversation as resolved.
Outdated
}

private void cleanExtraOutputFilesForUpdate(ConnectorSession session, Location baseLocation, List<DataFileInfo> newFiles)
{
Set<Location> writtenFilePaths = newFiles.stream()
.map(dataFileInfo -> baseLocation.appendPath(dataFileInfo.getPath()))
.collect(toImmutableSet());

cleanExtraOutputFiles(session, writtenFilePaths);
}

private void cleanExtraOutputFiles(ConnectorSession session, Set<Location> validWrittenFilePaths)
{
Set<Location> fileLocations = validWrittenFilePaths.stream()
Expand Down