-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Use google.inject instead of javax.inject #17507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
When #17484 is pulled in, we can add a "restrict import" rule that will prohibit direct usage of javax.inject.* |
44254d0 to
fd56adf
Compare
|
This PR was prepared semi-automatically using a combination of sed, sift and IntelliJ |
|
Recipe: |
86dcec5 to
3ec3dbb
Compare
6f15b6f to
1b5d448
Compare
We should use either google.inject or javax/jakarta.inject interfaces and annotations. We will not switch to some DI framework other than Guice, thus having consistent usage of google.inject makes more sense as it's easier to switch to Guice 7.0 in the future which brings support for jakarta.inject namespace.
1b5d448 to
8c169d2
Compare
|
Please update modernizer to prevent their return. |
|
@kokosing not needed. It's banned dependency. |
We should use either google.inject or javax/jakarta.inject interfaces and annotations.
We will not switch to some DI framework other than Guice, thus having consistent usage of google.inject makes more sense as it's easier to switch to Guice 7.0 in the future which brings support for jakarta.inject namespace.
For reference:
From the code execution perspective, this is a no-op.
Description
Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: