Update to Java 11/17 Oracle JDBC driver #17489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
changed the title
ebyhr
reviewed
May 14, 2023
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Did you miss updating trino-oracle module?
Member
Author
Sure did... was hacking during Open Source Summit. Add the update now. |
Member
Author
|
From what I can tell the CI failure is a false alarm. Can you confirm @ebyhr ? |
ebyhr
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Could also update to 23.2.0.0 but that is a "Developer release"
Additional context and related issues
Our required runtime is Java 17 .. we should at least use the JDBC driver for Java 11/17 .. not the one for Java 8/11.
Fixes #6714
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: