Skip to content

Collect stats for primitive fields inside ROW column in Delta connector#17486

Closed
krvikash wants to merge 1 commit intotrinodb:masterfrom
krvikash:krvikash/delta-collect-stats-for-primitive-field-inside-row
Closed

Collect stats for primitive fields inside ROW column in Delta connector#17486
krvikash wants to merge 1 commit intotrinodb:masterfrom
krvikash:krvikash/delta-collect-stats-for-primitive-field-inside-row

Conversation

@krvikash
Copy link
Copy Markdown
Contributor

@krvikash krvikash commented May 12, 2023

Description

Fixes: #17164

  1. x ROW(a INT, b VARCHAR) -> Stats collected for { x.a, x.b }
  2. x ROW(a INT, y ROW(b INT, c STRING)) -> Stats collected for { x.a, x.y.b, x.y.c }
  3. x ROW(a INT, b ARRAY[INT], c MAP(INT, INT)) -> Stats collected for { x.a }
  4. x ROW(a INT, y ROW(b INT, c ARRAY[INT], MAP(INT, INT))) -> Stats collected for { x.a, x.y.b }

Release notes

(X) Release notes are required, with the following suggested text:

# Delta
* Collect stats for primitive fields inside `row` ({issue}`17486`)

@cla-bot cla-bot bot added the cla-signed label May 12, 2023
@github-actions github-actions bot added the delta-lake Delta Lake connector label May 12, 2023
@krvikash krvikash force-pushed the krvikash/delta-collect-stats-for-primitive-field-inside-row branch 4 times, most recently from b538ff2 to adce95e Compare May 16, 2023 20:11
@krvikash
Copy link
Copy Markdown
Contributor Author

@krvikash : TODO test stats collection for column mapping mode

@krvikash krvikash force-pushed the krvikash/delta-collect-stats-for-primitive-field-inside-row branch 3 times, most recently from a6252e0 to aab2664 Compare May 16, 2023 20:19
@krvikash krvikash force-pushed the krvikash/delta-collect-stats-for-primitive-field-inside-row branch from aab2664 to 789b87a Compare May 16, 2023 21:56
@krvikash krvikash marked this pull request as ready for review May 17, 2023 05:08
@krvikash krvikash requested review from ebyhr, findinpath and pajaks May 18, 2023 05:10
@krvikash krvikash force-pushed the krvikash/delta-collect-stats-for-primitive-field-inside-row branch from 789b87a to bc291c4 Compare June 12, 2023 07:24
@krvikash
Copy link
Copy Markdown
Contributor Author

rebased and resolved conflicts

@krvikash krvikash force-pushed the krvikash/delta-collect-stats-for-primitive-field-inside-row branch 2 times, most recently from 53d8af3 to 090ccda Compare June 19, 2023 22:20
@krvikash krvikash force-pushed the krvikash/delta-collect-stats-for-primitive-field-inside-row branch from 090ccda to 073c34b Compare August 12, 2023 09:10
@krvikash
Copy link
Copy Markdown
Contributor Author

(rebased and resolved conflicts)

@krvikash krvikash force-pushed the krvikash/delta-collect-stats-for-primitive-field-inside-row branch from 073c34b to f9bd196 Compare August 12, 2023 10:32
@github-actions
Copy link
Copy Markdown

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Jan 15, 2024
@mosabua
Copy link
Copy Markdown
Member

mosabua commented Jan 15, 2024

👋 @krvikash - this PR has become inactive. We hope you are still interested in working on it. Please let us know, and we can try to get reviewers to help with that.

We're working on closing out old and inactive PRs, so if you're too busy or this has too many merge conflicts to be worth picking back up, we'll be making another pass to close it out in a few weeks.

@github-actions github-actions bot removed the stale label Jan 16, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 7, 2024

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Feb 7, 2024
@github-actions
Copy link
Copy Markdown

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@github-actions github-actions bot closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

Collect statistics for complex types in the Delta Lake connector

2 participants