Skip to content

Conversation

@findepi
Copy link
Member

@findepi findepi commented May 12, 2023

Docker build involves network operations and some of them do not have implicit retries. For example, the command

git clone https://github.com/airlift/jvmkill /tmp/jvmkill

currently does not retry.

fixes #17472

Docker build involves network operations and some of them do not have
implicit retries. For example, the command

    git clone https://github.com/airlift/jvmkill /tmp/jvmkill

currently does not retry.
@findepi findepi requested review from hashhar, homar and nineinchnick May 12, 2023 08:25
@cla-bot cla-bot bot added the cla-signed label May 12, 2023
@findepi findepi merged commit c68b030 into trinodb:master May 12, 2023
@findepi findepi deleted the findepi/retry-docker-build-6d2801 branch May 12, 2023 12:54
@github-actions github-actions bot added this to the 418 milestone May 12, 2023
@electrum
Copy link
Member

This isn't the right way. We should not have a script in core/docker depend on .github/bin which is for CI build scripts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

ci / artifact-checks flaky failure when cloning jvmkill

5 participants