-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Use by default ZSTD
Parquet compression codec for Delta Lake
#17426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use by default ZSTD
Parquet compression codec for Delta Lake
#17426
Conversation
/test-with-secrets sha=3a66eaefac8743b41b53098bad3d31a28a9a00df |
...ava/io/trino/tests/product/launcher/env/environment/EnvSinglenodeDeltaLakeDatabricks104.java
Outdated
Show resolved
Hide resolved
...product-tests/src/main/java/io/trino/tests/product/deltalake/BaseTestDeltaLakeS3Storage.java
Outdated
Show resolved
Hide resolved
...a/io/trino/tests/product/launcher/env/environment/AbstractSinglenodeDeltaLakeDatabricks.java
Outdated
Show resolved
Hide resolved
...a/io/trino/tests/product/launcher/env/environment/AbstractSinglenodeDeltaLakeDatabricks.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/trino/tests/product/deltalake/TestDeltaLakeDatabricksInsertCompatibility.java
Outdated
Show resolved
Hide resolved
...c/main/java/io/trino/tests/product/deltalake/TestDeltaLakeDatabricksInsertCompatibility.java
Outdated
Show resolved
Hide resolved
3a66eae
to
db6136c
Compare
@findepi pls run the PR again with secrets |
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/4936844641 |
/test-with-secrets sha=db6136c7157a841809d0ae9ed4ff9702754bc141 |
did it run? |
Yes, it was green in https://github.com/trinodb/trino/actions/runs/4944033785 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...product-tests/src/main/java/io/trino/tests/product/deltalake/BaseTestDeltaLakeS3Storage.java
Outdated
Show resolved
Hide resolved
...er/presto-product-tests/conf/environment/singlenode-delta-lake-databricks91/delta.properties
Outdated
Show resolved
Hide resolved
...er/presto-product-tests/conf/environment/singlenode-delta-lake-databricks91/delta.properties
Outdated
Show resolved
Hide resolved
db6136c
to
94f4831
Compare
/test-with-secrets sha=94f48315b8c97489c48e0962ec2922d7b47f75da
|
What compression level (1-22) is used with Trino zstd? |
...esto-product-tests/conf/environment/singlenode-delta-lake-databricks-snappy/delta.properties
Outdated
Show resolved
Hide resolved
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
@findinpath could you rebase and then work with @raunaqmorarka @ebyhr and others as needed? |
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
Now that we have native compression and decompression for ZSTD and #24553 to deprecate DB 9.1, I think this PR can go ahead. |
94f4831
to
45552cb
Compare
/test-with-secrets sha=45552cb195d3d4dfa9e3b10998cbef11f319e8a9 |
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/12481074009 |
45552cb
to
d7e9722
Compare
d7e9722
to
f2d09ac
Compare
/test-with-secrets sha=f2d09ac4fd93a0a5edc638606953352c877d9280 |
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/12484498657 |
Description
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: