Skip to content

Analyze json_table invocation #17415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kasiafi wants to merge 1 commit into from
Closed

Analyze json_table invocation #17415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 44 additions & 11 deletions core/trino-main/src/main/java/io/trino/sql/analyzer/Analysis.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@
import io.trino.sql.tree.Identifier;
import io.trino.sql.tree.InPredicate;
import io.trino.sql.tree.Join;
import io.trino.sql.tree.JsonTable;
import io.trino.sql.tree.JsonTableColumnDefinition;
import io.trino.sql.tree.LambdaArgumentDeclaration;
import io.trino.sql.tree.MeasureDefinition;
import io.trino.sql.tree.Node;
Expand Down Expand Up @@ -159,9 +161,10 @@ public class Analysis
private final Set<NodeRef<FunctionCall>> patternAggregations = new LinkedHashSet<>();

// for JSON features
private final Map<NodeRef<Expression>, JsonPathAnalysis> jsonPathAnalyses = new LinkedHashMap<>();
private final Map<NodeRef<Node>, JsonPathAnalysis> jsonPathAnalyses = new LinkedHashMap<>();
private final Map<NodeRef<Expression>, ResolvedFunction> jsonInputFunctions = new LinkedHashMap<>();
private final Map<NodeRef<Expression>, ResolvedFunction> jsonOutputFunctions = new LinkedHashMap<>();
private final Map<NodeRef<Node>, ResolvedFunction> jsonOutputFunctions = new LinkedHashMap<>();
private final Map<NodeRef<JsonTable>, JsonTableAnalysis> jsonTableAnalyses = new LinkedHashMap<>();

private final Map<NodeRef<QuerySpecification>, List<FunctionCall>> aggregates = new LinkedHashMap<>();
private final Map<NodeRef<OrderBy>, List<Expression>> orderByAggregates = new LinkedHashMap<>();
Expand Down Expand Up @@ -202,7 +205,7 @@ public class Analysis
private final Map<NodeRef<Expression>, Type> sortKeyCoercionsForFrameBoundComparison = new LinkedHashMap<>();
private final Map<NodeRef<Expression>, ResolvedFunction> frameBoundCalculations = new LinkedHashMap<>();
private final Map<NodeRef<Relation>, List<Type>> relationCoercions = new LinkedHashMap<>();
private final Map<NodeRef<Expression>, RoutineEntry> resolvedFunctions = new LinkedHashMap<>();
private final Map<NodeRef<Node>, RoutineEntry> resolvedFunctions = new LinkedHashMap<>();
private final Map<NodeRef<Identifier>, LambdaArgumentDeclaration> lambdaArgumentReferences = new LinkedHashMap<>();

private final Map<Field, ColumnHandle> columns = new LinkedHashMap<>();
Expand Down Expand Up @@ -647,12 +650,12 @@ public void registerTable(
columnMaskScopes.isEmpty()));
}

public ResolvedFunction getResolvedFunction(Expression node)
public ResolvedFunction getResolvedFunction(Node node)
{
return resolvedFunctions.get(NodeRef.of(node)).getFunction();
}

public void addResolvedFunction(Expression node, ResolvedFunction function, String authorization)
public void addResolvedFunction(Node node, ResolvedFunction function, String authorization)
{
resolvedFunctions.put(NodeRef.of(node), new RoutineEntry(function, authorization));
}
Expand Down Expand Up @@ -1007,14 +1010,19 @@ public boolean isPatternAggregation(FunctionCall function)
return patternAggregations.contains(NodeRef.of(function));
}

public void setJsonPathAnalyses(Map<NodeRef<Expression>, JsonPathAnalysis> pathAnalyses)
public void setJsonPathAnalyses(Map<NodeRef<Node>, JsonPathAnalysis> pathAnalyses)
{
jsonPathAnalyses.putAll(pathAnalyses);
}

public JsonPathAnalysis getJsonPathAnalysis(Expression expression)
public void setJsonPathAnalysis(Node node, JsonPathAnalysis pathAnalysis)
{
return jsonPathAnalyses.get(NodeRef.of(expression));
jsonPathAnalyses.put(NodeRef.of(node), pathAnalysis);
}

public JsonPathAnalysis getJsonPathAnalysis(Node node)
{
return jsonPathAnalyses.get(NodeRef.of(node));
}

public void setJsonInputFunctions(Map<NodeRef<Expression>, ResolvedFunction> functions)
Expand All @@ -1027,14 +1035,24 @@ public ResolvedFunction getJsonInputFunction(Expression expression)
return jsonInputFunctions.get(NodeRef.of(expression));
}

public void setJsonOutputFunctions(Map<NodeRef<Expression>, ResolvedFunction> functions)
public void setJsonOutputFunctions(Map<NodeRef<Node>, ResolvedFunction> functions)
{
jsonOutputFunctions.putAll(functions);
}

public ResolvedFunction getJsonOutputFunction(Expression expression)
public ResolvedFunction getJsonOutputFunction(Node node)
{
return jsonOutputFunctions.get(NodeRef.of(node));
}

public void addJsonTableAnalysis(JsonTable jsonTable, JsonTableAnalysis analysis)
{
jsonTableAnalyses.put(NodeRef.of(jsonTable), analysis);
}

public JsonTableAnalysis getJsonTableAnalysis(JsonTable jsonTable)
{
return jsonOutputFunctions.get(NodeRef.of(expression));
return jsonTableAnalyses.get(NodeRef.of(jsonTable));
}

public Map<AccessControlInfo, Map<QualifiedObjectName, Set<String>>> getTableColumnReferences()
Expand Down Expand Up @@ -2333,4 +2351,19 @@ public ConnectorTransactionHandle getTransactionHandle()
return transactionHandle;
}
}

public record JsonTableAnalysis(
CatalogHandle catalogHandle,
ConnectorTransactionHandle transactionHandle,
Type parametersRowType,
List<NodeRef<JsonTableColumnDefinition>> orderedOutputColumns)
{
public JsonTableAnalysis
{
requireNonNull(catalogHandle, "catalogHandle is null");
requireNonNull(transactionHandle, "transactionHandle is null");
requireNonNull(parametersRowType, "parametersRowType is null");
requireNonNull(orderedOutputColumns, "orderedOutputColumns is null");
}
}
}
Loading